Open
Conversation
Author
|
Using docker and docker compose, i manage to link the two images and run in as app along with DB. |
CodelineAtyab
requested changes
Aug 8, 2024
Owner
There was a problem hiding this comment.
Target directory can be excluded from the pull request changes as its host specific
| FROM maven:3.8.1-openjdk-17 AS build | ||
| WORKDIR /app | ||
| COPY pom.xml . | ||
| RUN mvn dependency:go-offline -B |
Owner
There was a problem hiding this comment.
Please add a comment mentioning the benefit of using go-offline -B
Isn't mvn clean package going to package the app with all the dependencies ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.